Tom Morton is sharing code with you

Bitbucket is a code hosting site. Unlimited public and private repositories. Free for small teams.

Don't show this again

errant / eventscripts-xa

Welcome to the eXtensible Admin bug tracker and code repository. Please report all bugs you may find.

Clone this repository (size: 5.7 MB): HTTPS / SSH 
hg clone https://bitbucket.org/errant/eventscripts-xa
hg clone ssh://hg@bitbucket.org/errant/eventscripts-xa

Issues

#65 Error in xaadvert

Reported anonymously

04/26/10 17:21:23 Traceback (most recent call last): File "/srcds2/cstrike/addons/eventscripts/es.py", line 211, in tick x() File "/srcds2/cstrike/addons/eventscripts/_libs/python/gamethread.py", line 173, in tick _executenode(first) File "/srcds2/cstrike/addons/eventscripts/_libs/python/gamethread.py", line 155, in _executenode function(*a, kw) File "/srcds2/cstrike/addons/eventscripts/xa/modules/xaadvert/xaadvert.py", line 129, in display_advert advert_text = advert_text.replace('{NEXTMAP}', mapcycle[currentmap+1]) IndexError: list index out of range

Status: resolved Responsible: Steven Hartin Type: bug Priority: major
Milestone: scrum Component: none Version: 1.1.0.x

Attachments

Comments and changes

  1. #1 Anonymous

    written

    Revision 542 fixed this already

  2. #2 Steven Hartin

    written

    • Changed status from new to resolved.
    • Changed responsible from nobody to freddukes.
  3. #3 Anonymous

    written

    Hey with your fixed version of xaadvert I still have issues in my errorlogs

    04/27/10 21:33:26 Traceback (most recent call last): File "/srcds/cstrike/addons/eventscripts/es.py", line 211, in tick x() File "/srcds/cstrike/addons/eventscripts/_libs/python/gamethread.py", line 173, in tick _executenode(first) File "/srcds/cstrike/addons/eventscripts/_libs/python/gamethread.py", line 155, in _executenode function(*a, kw) File "/srcds/cstrike/addons/eventscripts/xa/modules/xaadvert/xaadvert.py", line 133, in display_advert advert_text = advert_text.replace('{NEXTMAP}', mapcycle[currentmap+1]) IndexError: list index out of range

  4. #4 James Y

    written

    Anonymous is actually me btw :P

  5. #5 James Y

    written

    • Changed status from resolved to open.
  6. #6 James Y

    written

    Current xaadvert.py: 

    # ==============================================================================
#   IMPORTS
# ==============================================================================
# Python Imports
import re
import time

# EventScripts Imports
import es
import gamethread
import playerlib
import msglib
import usermsg

# XA Imports
from xa import xa

# ==============================================================================
#   ADDON REGISTRATION
# ==============================================================================
# Register with EventScripts
info = es.AddonInfo()
info.name       = 'Advert' 
info.version    = '1.1' 
info.author     = 'Rio'
info.basename   = 'xaadvert' 

# Register with XA
xaadvert = xa.register(info.basename) 
adverts              = xaadvert.setting.createVariable('adverts', 1, 'Turns adverts on or off') 
time_between_advert  = xaadvert.setting.createVariable('time_between_advert', 120, 'Time between adverts displayed') 
adverts_chat_area    = xaadvert.setting.createVariable('adverts_chat_area', 1, 'Allow adverts in chat area of screen') 
adverts_top_left     = xaadvert.setting.createVariable('adverts_top_left', 1, 'Allow adverts in top left corner of screen') 
advert_col_red       = xaadvert.setting.createVariable('advert_col_red', 0, 'Red component colour of adverts (255 = max)') 
advert_col_green     = xaadvert.setting.createVariable('advert_col_green', 0, 'Green component colour of adverts (255 = max)') 
advert_col_blue      = xaadvert.setting.createVariable('advert_col_blue', 255, 'Blue component colour of adverts (255 = max)') 
advert_dead_only     = xaadvert.setting.createVariable('advert_dead_only', 0, 'Specify if all players or only dead players can see adverts') 
adverts_bottom_area  = xaadvert.setting.createVariable('adverts_bottom_area', 0, 'Show adverts in the hint text area') 

if xa.isManiMode():
   xaadvertlist = xaadvert.configparser.getList('cfg/mani_admin_plugin/adverts.txt', True)
else:
   xaadvertlist = xaadvert.configparser.getList('adverts.txt')
if not xaadvertlist:
    raise ImportError('No adverts.txt found!')

# ==============================================================================
#   GLOBALS
# ==============================================================================
mapcycle = []
currentmap = None
next_advert = 0 
colors = {'{RED}': '255 0 0 255', '{BLUE}': '0 0 255 255', '{GREEN}': '0 255 0 255', '{MAGENTA}': '139 0 139 255', '{BROWN}': '128 42 42 255', '{GREY}': '128 128 128', '{CYAN}':  '0 204 204 255', '{YELLOW}': '255 255 0 255', '{ORANGE}': '255 127 0 255', '{WHITE}': '255 255 255 255', '{PINK}': '255 0 204 255'} 

# ==============================================================================
#   GAME EVENTS
# ==============================================================================
def load(): 
   # start timer 
   gamethread.delayedname(float(time_between_advert), 'adverts', display_advert) 
   
   es_map_start({'mapname':es.ServerVar('eventscripts_currentmap')})

def unload(): 
   # stop timer 
   gamethread.cancelDelayed('adverts') 
   
   # unregister module with XA 
   xaadvert.unregister() 

def es_map_start(event_var):
   global currentmap
   map_cycle()
   if event_var['mapname'] in mapcycle:
      if not currentmap or (mapcycle.index(event_var['mapname']) != currentmap+1):
         currentmap = mapcycle.index(event_var['mapname'])
      else:
         currentmap += 1
         if currentmap >= len(mapcycle):
            currentmap = 0
   else:
      currentmap = -1

# ==============================================================================
#   HELPER METHODS
# ==============================================================================
def map_cycle():
   global mapcycle
   mapcycle = filter(map_check, xaadvert.configparser.getList(str(es.ServerVar('mapcyclefile')), True))
   if not mapcycle:
      mapcycle = ['UNKNOWN']

def map_check(mapname):
   if es.exists('map', mapname):
      return True
   else:
      es.dbgmsg(0, 'XAAdvert: Unable to find map: %s.' % mapname)
      return False

def display_advert(): 
   global next_advert 
    
   # repeat the timer 
   gamethread.delayedname(float(time_between_advert), 'adverts', display_advert) 
    
   if adverts and xaadvertlist and es.ServerVar('eventscripts_currentmap') != '': 
      # start at the beginning 
      if next_advert >= len(xaadvertlist): 
         next_advert = 0 
          
      # get advert          
      advert_text = xaadvertlist[next_advert] 
            
      tags = re.compile(r'(?P<tag>\{\w+\})') 
      for tag in tags.findall(advert_text):              
         advert_text = advert_text.replace(tag,tag.upper()) 

      # set color 
      color = '%s %s %s 255' % (str(advert_col_red), str(advert_col_green), str(advert_col_blue)) 
      for k in colors: 
         if k in advert_text: 
            color = colors[k] 
            advert_text = advert_text.replace(k, '') 
                        
                
      # set tags 
      if str(es.ServerVar('eventscripts_nextmapoverride')) != '': 
         advert_text = advert_text.replace('{NEXTMAP}', str(es.ServerVar('eventscripts_nextmapoverride'))) 
      else: 
         if len(mapcycle) == 1:
             advert_text = advert_text.replace('{NEXTMAP}', str(es.ServerVar('eventscripts_currentmap')))
         else:
             advert_text = advert_text.replace('{NEXTMAP}', mapcycle[currentmap+1]) 
          
      advert_text = advert_text.replace('{CURRENTMAP}', str(es.ServerVar('eventscripts_currentmap'))) 
      advert_text = advert_text.replace('{TICKRATE}', 'UNKNOWN') 
      
      if int(es.ServerVar('mp_friendlyfire')): 
         advert_text = advert_text.replace('{FF}', 'on') 
      else: 
         advert_text = advert_text.replace('{FF}', 'off') 
          
      advert_text = advert_text.replace('{THETIME}', str(time.strftime("%H:%M:%S", time.localtime()))) 
      advert_text = advert_text.replace('{SERVERHOST}', 'UNKNOWN') 

      # send top text  
      if int(adverts_top_left):
         if int(advert_dead_only) == 1: 
            xaadvert_playerlist = playerlib.getPlayerList('#human,#dead') 
         else: 
            xaadvert_playerlist = playerlib.getPlayerList('#human') 
            
         toptext = msglib.VguiDialog(title=advert_text, level=5, time=25, mode=msglib.VguiMode.MSG) 
         toptext['color'] = color 

         for k in xaadvert_playerlist: 
            toptext.send(k.userid) 
            
      # send chat text  
      if int(adverts_chat_area):
         if int(advert_dead_only) == 1: 
            xaadvert_playerlist = playerlib.getPlayerList('#human,#dead') 
            for k in xaadvert_playerlist: 
               es.tell(k.userid, '#lightgreen', advert_text) 
         else: 
            es.msg('#lightgreen', advert_text) 
      
      # send bottom text 
      if int(adverts_bottom_area):
         if int(advert_dead_only) == 1: 
            xaadvert_playerlist = playerlib.getPlayerList('#human,#dead') 
         else: 
            xaadvert_playerlist = playerlib.getPlayerList('#human') 
            
         for k in xaadvert_playerlist: 
            usermsg.hudhint(k.userid, advert_text) 
            
      next_advert = next_advert + 1
  7. #7 James Y

    written

  8. #8 Tom Morton

    written

    • Changed status from open to resolved.

    clean up the map index assignment - and fixes #65 (the extra bug that crept in)

    → f79b6c19c576

  9. #9 Tom Morton

    written

    Give the latest copy a try - I put in an elif statement to catch where I think the error comes in (if you are on the last map of a maplist)

  10. #10 Anonymous

    written

    Thanks errant your da bomb

Add comment / attachment

Verification: Please write the text from the image in the box (letters only)

captcha

Is that you, Humanoid? Is this me?